Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why First and Last Point was not yielded? #9

Closed
marscarl59 opened this issue Apr 15, 2018 · 3 comments
Closed

Why First and Last Point was not yielded? #9

marscarl59 opened this issue Apr 15, 2018 · 3 comments

Comments

@marscarl59
Copy link

It is a question, not a issue. It is noticed "The generator never yields the first and the last points in the series."
Would it be better to yield first and last point as well?
@iamlikeme
Copy link
Owner

You can find explanation in #4
Now that you mention it, I think it might be useful to control this behavior with a keyword argument.

@iamlikeme iamlikeme mentioned this issue Apr 15, 2018
Merged
@iamlikeme
Copy link
Owner

I added keyword arguments left and right which allow you to treat the first and the last points as reversals (i.e. they would be yielded by the reversals generator). See #10.

@iamlikeme
Copy link
Owner

Published to PyPI as v2.1.1

@caweramboll caweramboll mentioned this issue Feb 25, 2020
Closed
@iamlikeme iamlikeme mentioned this issue Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iamlikeme @marscarl59