Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setCoverDrawable and API level <= 21 #5

Closed
DubiousCactus opened this issue Jan 20, 2016 · 4 comments
Closed

setCoverDrawable and API level <= 21 #5

DubiousCactus opened this issue Jan 20, 2016 · 4 comments

Comments

@DubiousCactus
Copy link
Contributor

Hi !
There is an error on the "getDrawable" call in your method "setCoverDrawable". I fixed it on my fork by adding "getResources" right before "getDrawable", but it looks like the fix doesn't take effect ... Could you fix it on your repo ?

Thanks !

Théo
@DubiousCactus
Copy link
Contributor Author

Okay I fixed it on my repo and used it with JitPack, but I don't know if I can fix it on yours, just letting you know ;)
And thanks a lot for this awesome work !

@iammert
Copy link
Owner

iammert commented Jan 20, 2016

I will be happy if you send me PR about this! Thanks.

@DubiousCactus
Copy link
Contributor Author

Done ! :)

@iammert
Copy link
Owner

iammert commented Jan 21, 2016

I merged your PR. Thanks for contribution:)

@iammert iammert closed this as completed Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DubiousCactus @iammert