Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request: Changes #13

Closed
imbaimbaimba opened this issue Feb 16, 2019 · 1 comment
Closed

Update request: Changes #13

imbaimbaimba opened this issue Feb 16, 2019 · 1 comment

Comments

@imbaimbaimba
Copy link

Hi,

I posted on your home assistant forum thread. However, I will also add it here:

First of all, I noticed that “Feels like” and “Today’s high” did not translate to Danish. I asked on the home assistant discord server, and got help figuring it out, including the next things I found.

I changed the fr case to:
case “da” :
return {
feelsLike: “Føles som”,
maxToday: “Højeste i dag”,

And it worked. Then I found that wind directions also did not translate, and were only written as acronyms, where I would prefer written out. So I changed it to:
const windDirections_da = [‘Nord’,‘Nord-Nordøst’,‘Nordøst’,‘Øst-Nordøst’,‘Øst’,‘Øst-Sydøst’,‘Sydøst’,‘Syd-Sydøst’,‘Syd’,‘Syd-Sydvest’,‘Sydvest’,‘Vest-Sydvest’,‘Vest’,‘Vest-Nordvest’,‘Nordvest’,‘Nord-Nordvest’,‘Nord’];

Then I noticed my wind speed was reporting km/h, where it should report km/t (hours = timer in danish). But adding it this, it was also giving me the m/s value and putting km/h unit on it. Lastly, I think the way of reporting the wind speed and direction was unnatural, so I changed it to report like “speed” from “direction”. I found out that changing the wind variable could do it:
var wind = this.config.entity_wind_speed && this.config.entity_wind_bearing ? html

  • ${this.current.beaufort}${this.current.windSpeed} m/s fra ${this.current.windBearing}
  • : ``;

    Can you maybe include these things? :)

    @iammexx
    Copy link
    Owner

    iammexx commented Feb 16, 2019

    See response in forum....

    @iammexx iammexx closed this as completed Feb 22, 2019
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants