Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad fails in IE with writeCapture #40

Open
brewt opened this issue Oct 27, 2011 · 7 comments
Open

Ad fails in IE with writeCapture #40

brewt opened this issue Oct 27, 2011 · 7 comments

Comments

@brewt
Copy link
Contributor

brewt commented Oct 27, 2011

I've been banging my head for a couple hours trying to debug this one, but haven't gotten anywhere. I hope someone can help with this. I have a "simple" example here:

http://jsfiddle.net/Nn5pR/2/
http://jsfiddle.net/9qQSP/ (no writeCapture)

In Firefox, you get the green IBM Flash ad, but in IE (all versions), you don't get anything. I'm leaning towards this being a problem with the way the ad code works, but would love to see a work around in writeCapture.

It seems to do everything right until right before it loads the actual swf file.

Any ideas? Thanks!

Adrian

@iamnoah
Copy link
Owner

iamnoah commented Oct 27, 2011

There is quite a bit of browser detection. This is the source I see: http://jsfiddle.net/uuEFF/

Unfortunately, I have no idea what it might be doing that causes the issue. I assume you have tried all the different options?

@ghost
Copy link

ghost commented Nov 2, 2011

I checked this because I'm considering using this for async ads too, but it needs to be cross-platform and support IE7 and later. I tried it on XP with IE8, Chrome 15, and Firefox 7, and Chrome was the ONLY one that worked. So, this code doesn't work in Firefox either under Windows XP. I don't know the solution but hope this information will help someone else solve it. Also brewt are you sure you were using Firefox and not Chrome or Safari when you did your successful test?

@iamnoah
Copy link
Owner

iamnoah commented Nov 2, 2011

Have you tried passing all the different options to writeCapture? https://github.com/iamnoah/writeCapture/wiki/Options

You might also try the user list: http://groups.google.com/group/writecapturejs-users

@brewt
Copy link
Contributor Author

brewt commented Nov 2, 2011

proxyGetElementById works, but only with the jQuery plugin (ie. doesn't work with nolib). But the problem is that the option breaks Google Adsense ads, so that isn't a viable solution.

@iamnoah
Copy link
Owner

iamnoah commented Nov 2, 2011

AdSense ads probably wont work at all... If for some reason they do work, you can make separate calls for AdSense and the other ads.

@brewt
Copy link
Contributor Author

brewt commented Nov 2, 2011

I believe Adsense is working for us here, but we haven't deployed writeCapture on the live site yet, so it's hard to tell which ones are broken due to Adsense not liking our dev domain and which are due to writeCapture.

@alexindigo
Copy link

I had similar problem with flash ads not showing in IE.

But if you trigger rendering it will show the ad.

Originally I added trigger to the closing tag for 'OBJECT' (element.write),
but when you have more than one element on the page IE7 crashes.

So in my final version I added following code to the writeCapture.close method:

        else if(listeners.done)
        {

          if (id == 0 && navigator.userAgent.match(/MSIE/))
          {
            setTimeout(function()
            {
              document.body.innerHTML = document.body.innerHTML + '';
            }, 100);
          }

          return listeners.done();
        }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants