Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify to receive speaker information from server #3

Closed
wants to merge 1 commit into from

Conversation

yjaeseok
Copy link

@yjaeseok yjaeseok commented Aug 6, 2019

Currently speaker information is provided hard coded data.
So If speaker information is changed, user need to update application.
For this reason, I modify to receive speaker information from server.

I am not sure, it is required feature or not.
But I think most gdg organizer want to use speaker data from server like this change list.
If you have any concern. please tell me.

@iampawan
Copy link
Owner

iampawan commented Aug 6, 2019

Hi, @yjaeseok thanks for the awesome PR. As you said all the information is hardcoded as of now. I am working on making it as much easy to customize as I can. Everyone is consuming data in a different way so I am trying to build something common. I am making a rest-client implementation as of now so that people like you can do network calls easily. Then I'll also add firebase to it. I hope you got my point.

@yjaeseok
Copy link
Author

yjaeseok commented Aug 6, 2019

@iampawan Oh really, it sounds great for us.
I got your point, But I would like to contribute your source code more,
Because I am gdg organizer for preparing gdg devfest also :).
Could you give me some task for contributing your source?

@yjaeseok yjaeseok closed this Aug 6, 2019
@iampawan
Copy link
Owner

iampawan commented Aug 6, 2019

I will definitely let you know. For the time being, I'm pushing some changes to the repo in few mins. I would just like you to test it and give the feedback if that’s working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants