Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better moduling #8

Closed
squaremarco opened this issue Jun 11, 2021 · 0 comments · Fixed by #11
Closed

Better moduling #8

squaremarco opened this issue Jun 11, 2021 · 0 comments · Fixed by #11
Assignees
@squaremarco
Labels
enhancement New feature or request feature-port Port of a feature present on the original library help wanted Extra attention is needed
Projects
convert-units
Milestone
v2.0.0

Comments

@squaremarco
Copy link
Member

squaremarco commented Jun 11, 2021 •
edited
Loading

Port convert-units's v3 module capabilities so that you can import only a subset of measure definitions.
This will need an extensive typing refactor and a way to configure all the library's function by calling a specific method/factory/class.

NOTE: it should also enhance #9.
Translations should be exported from their own definition's module so that they can be imported individually.
@squaremarco squaremarco added enhancement New feature or request help wanted Extra attention is needed feature-port Port of a feature present on the original library labels Jun 11, 2021
@squaremarco squaremarco added this to the 2.0.0 milestone Jun 11, 2021
@squaremarco squaremarco added this to To do in convert-units via automation Jun 11, 2021
@squaremarco squaremarco moved this from To do to In progress in convert-units Jun 13, 2021
@squaremarco squaremarco mentioned this issue Jun 13, 2021
Closed
@squaremarco squaremarco self-assigned this Jun 13, 2021
@squaremarco squaremarco linked a pull request Jun 16, 2021 that will close this issue
Add better module handling #11
Merged
@squaremarco squaremarco moved this from In progress to Done 🎉 in convert-units Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@squaremarco squaremarco

Labels
enhancement New feature or request feature-port Port of a feature present on the original library help wanted Extra attention is needed
Projects
convert-units
Done 🎉
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Add better module handling iamsquare/convert-units
1 participant
@squaremarco