Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested .class++ isn't minified right #80

Open
vincentaudebert opened this issue Nov 3, 2016 · 2 comments
Open

Nested .class++ isn't minified right #80

vincentaudebert opened this issue Nov 3, 2016 · 2 comments

Comments

@vincentaudebert
Copy link

Hi,

Just found a quite weird issue when dealing with some sass code like this:

.form__field\+\+ {
        ...

        @include smallish {
            .form__input,
            .form__select {
                display: inline-block;
                width: 60%;
            }
        }

        ...
}

It ends up generating something like this:

@media only screen and (min-width:480px){.form__field\+\+.form__input,.form__field\+\+.form__select{display:inline-block;width:60%}

As you can see this is breaking the CSS.

It should be

@media only screen and (min-width:480px){.form__field\+\+ .form__input,.form__field\+\+ .form__select{display:inline-block;width:60%}

But for some reasons the space after second escaped + is removed.

Any idea?

@vincentaudebert vincentaudebert changed the title Nested .class++ isn't compiled right Nested .class++ isn't minified right Nov 3, 2016
@iamvdo
Copy link
Owner

iamvdo commented Nov 3, 2016

This should be fixed in csswring now, npm update your modules, and let me know

@vincentaudebert
Copy link
Author

vincentaudebert commented Nov 3, 2016

Hi @iamvdo thanks a lot. Any chance you would bump gulp-pleeease or pleeease to use the right versions too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants