New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using setuptools and changed way versioning is done #24
Conversation
Conflicts: .gitignore CHANGES.txt EXIF.py README.md exifread/__init__.py exifread/utils.py setup.py
in a single place (modules __init__ file)
Hi Peter, Normally when doing pull requests it's best to separate into branches for each contribution, so here for example you could have one for the setuptools and another for the version stuff. At least, to have different commits so I can try to git cherry-pick. Reason being, the version changes I would accept as-is no problem, but I'm not sure about setuptools. I'm not very familiar with the differences between setuptools and distutils and have a few questions:
I've cherry-pick'ed the typo commit. Thank you, ianaré |
Forgot to say: |
Hi Ianare, i have never put anything on PyPi, but since setuptools is already used in packages on PyPi i don't think it will make difference. According to https://pypi.python.org/pypi/setuptools/1.1.6 setuptools "runs on Python 2.4 - Python 3.3 without Python 2to3 conversion" I have used it already for several packages which run with python 2.4.6 One advantage of setuptools is the handling of scripts, e.g. creating .exe extensions on windows (http://pythonhosted.org/distribute/setuptools.html#automatic-script-creation). But to be honest, i haven't tried, since i'm on Ubuntu. If you want to stick with distuls, thats fine with me. Regards, Peter |
OK, good to know. I think for now there isn't the need to move to setuptools, if this becomes blocking later it can be added. I'd like to get your fixes for the version stuff though, can you make another pull request from develop with the changes? Thanks much! |
Hi Ianare,
i saw that you have already included some of the modification i did on my fork of your exif-py. I merged those back to my fork and did a few more modification, which i put in this pull request. I hope i did it right, since i'm still more accustomed to svn than to git. I did not change too much:
I have a few more things in mind so you can expect some more pull requests if this one works as expected.
Regards,
Peter