New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correcty process the Makernote of some Canon models #49
Conversation
Correcty process the Makernote of some Canon models
Great, thank you! If you have some test images for this, can you provide them? This way I will add to the test images repo. |
ianare. Please copy them somewhere. I will delete them in the coming days. https://blog.jcea.es/canon_hdr_NO.jpg https://blog.jcea.es/iphone_hdr_NO.jpg The HDR images will be detected in two incoming pull requests. |
Images added here: https://github.com/ianare/exif-samples/tree/master/jpg/hdr So now these will be processed / tested on every Travis build. You can delete from you server when you want. Thanks for all your help. |
Good. Thanks. You will need to upgrade the tests when you accept the PR for Apple iOS HDR. |
Could you possibly update the README to credit me? :) |
I've added you to the changelog on exif-py and added a README in the hdr folder in exif-samples. If you want me to use your real name rather than your username, please let me know (or submit a PR). Thanks! |
I had to revert the changes to the ifd processing, all other images I tested with had missing Makernotes. |
Sorry for the regression. I only have a Canon PowerShot SX60 HS and I was expecting the Continuous Integration system to catch any issue. Do you take care of this? I can try but not immediately. |
For now I simply removed the code, but left the HDR tag definitions. |
Needed to correctly process Makernote of some Canon cameras. For instance Canon Powershot SX60.
After this pull request is accepted, I have two more about HDR tags.