Visible chars are now a parameter in onTyped #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbjorndilling
added a commit
that referenced
this pull request
Oct 31, 2015
Visible chars are now a parameter in onTyped
|
I'm sorry it took me so long to get to this! Your suggestion has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been in the situation where
tokenalone is not enough in theonTypedcallback. This happens when there are multiple occurrences of the same token in the text that's going to be displayed.With this pull request, the value of
prevState.visibleCharsis available as the second parameter in the callback, making it easier to make assumptions based on the token and the position.