Fix for reverse typing bug (Issue #31) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo for the fix: |
archieherbias
commented
Oct 11, 2018
| @@ -28,10 +28,12 @@ class TypeWriter extends React.Component { | |||
| const active = this.props.typing; | |||
|
|
|||
| if (active > 0 && next < 0) { | |||
| clearInterval(this._timeoutId); | |||
There was a problem hiding this comment.
This condition block here causes setting of visibleChars state to fire twice along with the _handleTimeout handler. So, clearing _handleTimeout is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug was caused by setting the
visibleCharsstate twice when proptypingis changed.Solution is to clear the
_handleTimeoutfrom running so that changing state won't fire twice.