Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of in-tree standalone #226

Closed
jsarenik opened this issue Jul 9, 2018 · 2 comments
Closed

get rid of in-tree standalone #226

jsarenik opened this issue Jul 9, 2018 · 2 comments

Comments

@jsarenik
Copy link
Contributor

jsarenik commented Jul 9, 2018

This is a suggestion in order to ease future development and get rid of bloated git history containing the compiled result.

Please have a look at jsarenik@5215311

lomidrevo:~/Downloads$ ls -lh bip39-*
-rw-r--r-- 1 jasan jasan 1.2M Jul  9 12:36 bip39-jasan-rewritten.zip
-rw-r--r-- 1 jasan jasan 2.4M Jul  9 12:36 bip39-master.zip

It might not be so bad yet, but I have seen repositories with hundreds of GBs of generated blob.

For reference: samhocevar/wincompose#16

bip39 is a wonderful piece of software. Thank you!
@jsarenik jsarenik changed the title get rid of standalone in tree get rid of in-tree standalone Jul 9, 2018
@iancoleman
Copy link
Owner

Good suggestion. Now that releases are being made it's a good idea to remove it from the repo. Thanks for the suggestion.

@jsarenik
Copy link
Contributor Author

You are welcome. Good job. Respect.

@iancoleman iancoleman mentioned this issue Apr 30, 2019
Closed
@jsarenik jsarenik mentioned this issue Oct 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsarenik @iancoleman and others