Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Symbolic Arithmetic #171

Open
ianfhunter opened this issue Sep 1, 2022 · 0 comments
Open

Test: Symbolic Arithmetic #171

ianfhunter opened this issue Sep 1, 2022 · 0 comments
Assignees

Comments

@ianfhunter
Copy link
Owner

Is your feature request related to a problem? Please describe.
Legacy Test that needs to be added to our test suit

Describe the solution you'd like
a roll of dF! should fail with an error as symbolic dice are not supported for explosions
Add to pytest tests in tests/python

Describe alternatives you've considered

Additional context

  • Subtraction can make no sense for string dice if they do not contain the same items
  • You also should not be able to add numbers and strings together
  • And you cannot use strings as a condition on numbers
    • You can do the reverse though.
  • String Math does not make sense most of the time

Legacy Tests (may be incorrect/outdated)

roll low high passes
"df+df" -- ++ False
"10df-2df" - ++++++++, True
"2df-20df" ++++++++++++++++++ ------------------ True
"d10+df" ----------- +++++++++++ True
"2d4x3df" ---- ++++++++++++++++++++++++++++ True
"2dF x 2d4" "--:--" "++:++:++:++:++:++:++:++" False
"3df!" --- +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ False

Error Cases:
"dF*dF"
"dF/dF"
"dF|dF"
"dF%dF"
"dF+dF","--","++",False
"dF-dF"

"dF*d3", "-","+++", False
"dF/d3"
"dF|d3"
"dF%d3"
"dF+d3"
"dF-d3"

@ianfhunter ianfhunter added the Feature Request New feature or request label Sep 1, 2022
@ianfhunter ianfhunter self-assigned this Sep 1, 2022
@ianfhunter ianfhunter added Test Request good first issue Good for newcomers hacktoberfest and removed Feature Request New feature or request labels Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant