Skip to content

Commit

Permalink
Minor tweaks related to IME code
Browse files Browse the repository at this point in the history
- Add comment to explain reason for code
- Change variable name to be more clear about its purpose
- Change to triple equals
  • Loading branch information
akavlie committed Mar 4, 2012
1 parent 38be96c commit bc72989
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions assets/js/views/chat.js
Expand Up @@ -42,7 +42,9 @@ var ChatView = Backbone.View.extend({
$('#chat-input').val('');
});

var isEnter = false;
// Only submit message on enter if both keydown & keyup are present
// so IMEs work
var keydownEnter = false;
$('#chat-input').bind({
// Enable button if there's any input
change: function() {
Expand All @@ -58,13 +60,13 @@ var ChatView = Backbone.View.extend({
if (event.keyCode == 9) {
event.preventDefault();
}
isEnter = (event.keyCode == 13);
keydownEnter = (event.keyCode === 13);
},

keyup: function(event) {
var self = this;
if ($(this).val().length) {
if (isEnter && event.keyCode == 13) {
if (keydownEnter && event.keyCode === 13) {
var message = $(this).val();
// Handle IRC commands
if (message.substr(0, 1) === '/') {
Expand Down

0 comments on commit bc72989

Please sign in to comment.