Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax type signatures of vector construction/transformation functions #143

Closed
ianmackenzie opened this issue Oct 19, 2020 · 0 comments
Closed

Relax type signatures of vector construction/transformation functions #143

ianmackenzie opened this issue Oct 19, 2020 · 0 comments
Assignees
@ianmackenzie
Labels
breaking change

Comments

@ianmackenzie
Copy link
Owner

ianmackenzie commented Oct 19, 2020 •
edited
Loading

Component units don't actually need to match frame/sketch plane units since the origin point is not used (only the basis directions, which are unitless). Match the style of Vector2d.mirrorAcross which uses axisUnits and units?

Vector2d

  • Vector2d.xyIn
  • Vector2d.rThetaIn
  • Vector2d.relativeTo
  • Vector2d.placeIn
  • Vector2d.projectOnto

Vector3d

  • Vector3d.xyzIn
  • Vector3d.on
  • Vector3d.xyOn
  • Vector3d.rThetaOn
  • Vector3d.relativeTo
  • Vector3d.placeIn
  • Vector3d.rotateAround
  • Vector3d.mirrorAcross
  • Vector3d.projectOnto
  • Vector3d.projectInto
@ianmackenzie ianmackenzie self-assigned this Oct 19, 2020
@ianmackenzie ianmackenzie changed the title Relax type signature of Vector2d.[xyIn, rThetaIn] and Vector3d.[xyzIn, xyOn, rThetaOn] Relax type signature of Vector2d.[xyIn, rThetaIn] and Vector3d.[xyzIn, on, xyOn, rThetaOn] Apr 6, 2021
@ianmackenzie ianmackenzie changed the title Relax type signature of Vector2d.[xyIn, rThetaIn] and Vector3d.[xyzIn, on, xyOn, rThetaOn] Relax type signatures of vector functions Apr 6, 2021
@ianmackenzie ianmackenzie changed the title Relax type signatures of vector functions Relax type signatures of vector construction/transformation functions Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianmackenzie ianmackenzie

Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianmackenzie