-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add several conversion, string, and logic functions (mostly from MS SQL Server) #26
Conversation
It looks like there aren't tests for translations in general. I'm not sure how that would work, but I'd be happy to provide some. |
Awesome, thank you @StevenHibble! I will take a closer look at this PR shortly. Correct, I haven't yet added comprehensive tests of the function translations. If you'd like to give that a go, please do. You could add a test script named |
P.S. The main reason that the codecov test coverage is not at or near 100% is that many of the function translations are currently not tested! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great—thank you! I have just a few small change requests, and some questions and general discussion—please take a look at my comments. I'll wait to merge until after you push commits to address those (they should automatically get added to the PR).
I'll try to make these changes over the weekend. |
Thanks! And please don't feel any obligation to rush 🙂 |
R CMD check did throw this warning:
|
To stop those unstated dependencies warnings, you'll need to call tidyverse functions by using |
Thanks for the guidance. The references were in tests added for the |
Thank you @StevenHibble! I will review soon. |
Sorry for the epic delay in merging this. Thanks again for your work on this! |
This is a loose collection of additions to the translations. There is one fix that I noticed while looking for missing function (
nullif
's base R translation). Here's what is added:TRY_CAST
,CONVERT
, andTRY_CONVERT
) to complementCAST
STRING_AGG
,REVERSE
,REPLACE
,CHARINDEX
, andREPLICATE
)ISNULL
,NVL
,CHOOSE
)