Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error if called from an incompatible version of tidyquery #32

Closed
ianmcook opened this issue Aug 7, 2021 · 1 comment
Closed

Comments

@ianmcook
Copy link
Owner

ianmcook commented Aug 7, 2021

tidyquery imports queryparser and can require a minimum version of queryparser through R's usual method of specifying forward import versions. But this leaves open the possibility that a user might upgrade to a new version of queryparser but still have an older, incompatible version of tidyquery.

When queryparser is called from tidyquery, check its version and throw an error if the version is incompatible.

@ianmcook
Copy link
Owner Author

ianmcook commented Aug 7, 2021

To avoid needing to add utils to the queryparser dependencies, this exports the version number from tidyquery so we don't need to call utils::packageVersion() in queryparser: ianmcook/tidyquery@cef958e

@ianmcook ianmcook changed the title Throw error if called from an incompatible version of tidyquery Export version number Aug 7, 2021
@ianmcook ianmcook changed the title Export version number Throw error if called from an incompatible version of tidyquery Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant