Skip to content

/ tidyquery

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify dplyr code where possible #9

Closed
ianmcook opened this issue Jan 11, 2020 · 1 comment
Closed

Simplify dplyr code where possible #9

ianmcook opened this issue Jan 11, 2020 · 1 comment
Labels
enhancement

Comments

@ianmcook
Copy link
Owner

@ianmcook ianmcook commented Jan 11, 2020

The dplyr code generated by tidyquery is unnecessarily lengthy and complicated in some cases, like when the SQL query includes a GROUP BY clause and aggregate functions. This is because the generated dplyr code is optimized for maximum compatibility, not simplicity. To work in edge cases, tidyquery chains together sequences of dplyr verbs that are often longer than necessary.

Optimize the generated dplyr code by detecting cases where the code can be simpler.
@ianmcook
Copy link
Owner Author

@ianmcook ianmcook commented Jan 11, 2020

Started work in 15fd3ed
@ianmcook ianmcook closed this in 39c7171 Jan 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@ianmcook
You can’t perform that action at this time.