Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF::AzureAD::Application missing single_page_application #7

Open
andreialecu opened this issue Feb 27, 2024 · 3 comments
Open

TF::AzureAD::Application missing single_page_application #7

andreialecu opened this issue Feb 27, 2024 · 3 comments

Comments

@andreialecu
Copy link
Contributor

Azure now has a special single_page_application type, which doesn't seem to be directly documented here:
https://github.com/iann0036/cfn-tf-custom-types/blob/docs/resources/azuread/TF-AzureAD-Application/docs/README.md

It's been added a while back:
hashicorp/terraform-provider-azuread#474

I'm not sure what would need to be done here, I assume there's a script that could be used to re-generate everything?

@iann0036
Copy link
Owner

@andreialecu
Copy link
Contributor Author

Understood, do you plan on updating them in the main release as well?


PS: While running python3 generate.py azuread I first got:

subprocess.CalledProcessError: Command '['cfn', 'init', '--type-name', 'TF::AzureAD::SynchronizationSecret', '--artifact-type', 'RESOURCE', 'python37', '--use-docker']' returned non-zero exit status 1
... and many more

I manually ran cfn init and saw

➜ cfn init
ModuleNotFoundError: No module named 'pkg_resources'

For which I ran pip install setuptools and that fixed it.

Now getting:

subprocess.CalledProcessError: Command '['cfn', 'generate']' returned non-zero exit status 1.
... and many more

The error seems to be:

[2024-02-27T12:51:37Z] DEBUG    - Loading project file '/Users/andreialecu/Work/contrib/cfn-tf-custom-types/resources/azuread/TF-AzureAD-Application/.rpdk-config'
[2024-02-27T12:51:37Z] DEBUG    - Project file /Users/andreialecu/Work/contrib/cfn-tf-custom-types/resources/azuread/TF-AzureAD-Application/.rpdk-config not found. Have you run 'init' or in a wrong directory?

@andreialecu
Copy link
Contributor Author

andreialecu commented Feb 27, 2024

With the updates in #8 I was able to generate and submit the updated resource. However, it would be really great if you could update the main ones as well, because various cdk constructs, like: https://constructs.dev/packages/@cdk-cloudformation/tf-azuread-application/v/1.0.0-alpha.7?lang=typescript are being automatically generated from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants