Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture in Picture Mode on Firefox #45

Closed
raksdewji opened this issue May 10, 2020 · 8 comments
Closed

Picture in Picture Mode on Firefox #45

raksdewji opened this issue May 10, 2020 · 8 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@raksdewji
Copy link

Is there any chance we can get this option included for Firefox users?

@Chaphasilor
Copy link
Collaborator

It's not working on Firefox for Desktop? 👀

@Chaphasilor Chaphasilor self-assigned this May 31, 2020
@Chaphasilor Chaphasilor added the bug Something isn't working label May 31, 2020
@raksdewji
Copy link
Author

Currently getting this error when trying to toggle PiP
image

@Chaphasilor
Copy link
Collaborator

Okay, can you try right-clicking on the other participant's video and seeing if PiP is available through the context menu?

It seems like Firefox hasn't implemented the W3C PiP API yet because it's still a draft, but I'll check later if that is actually still the case!

@raksdewji
Copy link
Author

Tested on Linux and Windows and both had no PiP in the context menu.

image

@Chaphasilor
Copy link
Collaborator

Thanks for checking. I'll look into it tomorrow and see what options we have :)

@Chaphasilor
Copy link
Collaborator

Okay, so I just spent a almost two hours investigating, and I have bad news.

tl;dr: Firefox doesn't yet support picture in picture well enough so that we can use it in Zipcall :/

The issue here is twofold:

  1. Firefox is still using their own, proprietary implementation on pip. There is no API for toggling pip, only user gestures (fly-outs, context menus, etc.). That wouldn't be a huge problem of its own, but then there's the second problem:
  2. Their implementation doesn't seem to support more complex video sources, like webcam inputs or WebRTC streams yet. Only 'normal' videos with sources pointing either to a static video file or an m3u8-playlist file are supported. Because of this, we are unable to enable or provide a pip-mode in Firefox for now, it simply isn't possible from what I've found.
    There sadly isn't any official statement about that and very few info in general (aside from a StackOverflow question with negative score, no comments and no answers), so I might be wrong, but I don't think this is worth the effort right now.

Sorry to disappoint you :/

@Chaphasilor Chaphasilor added the wontfix This will not be worked on label Jun 6, 2020
@axtux
Copy link

axtux commented Aug 28, 2020

Firefox does not support picture in picture the way you could use it but the statement is wrong: Firefox does support picture in picture. I think the message should be updated to something like: Your browser does not support picture in picture for WebRTC streams. And maybe add a link to this issue if Firefox is detected?

@Chaphasilor
Copy link
Collaborator

@axtux yeah you're right, the error could be more specific. PRs are welcome ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants