Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer dependency management is not correct #1414

Closed
ianstormtaylor opened this issue Nov 16, 2017 · 0 comments · Fixed by #1539
Closed

peer dependency management is not correct #1414

ianstormtaylor opened this issue Nov 16, 2017 · 0 comments · Fixed by #1539

Comments

@ianstormtaylor
Copy link
Owner

ianstormtaylor commented Nov 16, 2017

Right now when a new minor version of Slate is published, the peerDependencies of all of the other packages are also bumped to that minor. This doesn't make sense, because the peer dependencies should stay as loose as possible.

For instance, in most cases when slate is upgraded, slate-prop-types is unaffected and can happily keep using older versions. But it is forced to upgrade currently regardless. This causes extra, unnecessary dependency upgrades to be forced on users.

This is actually due to a bug in Lerna — lerna/lerna#1018

If anyone was up for getting a pull request merged into Lerna to fix this behavior I would be super, super grateful. It would save a lot of headaches in the Slate ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant