Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase number of max normalization iterations #5222

Closed
Jacfem opened this issue Dec 13, 2022 · 1 comment · Fixed by #5295
Closed

Increase number of max normalization iterations #5222

Jacfem opened this issue Dec 13, 2022 · 1 comment · Fixed by #5295

Comments

@Jacfem
Copy link
Contributor

Jacfem commented Dec 13, 2022

Problem

The amount of max normalization iterations isn't enough for some large content in my app. It is set here as the number of dirty paths multiplied by 42. There's a comment next to the code that says //HACK: better way?. I'd love to learn more if bumping this multiplier is okay.

Solution

Either allow that 42 number to be configurable by the user, or increase that number. Locally, I've increased it to 100 and it fixes our use cases.

Alternatives
Open to suggestions!

Context
PR will be incoming.

I am curious if there are risks or concerns associated with this increase. I've applied the fix locally on my app and it fixes the issues. Thank you for your input!

@zbeyens
Copy link
Contributor

zbeyens commented Feb 13, 2023

I think that error is generally dangerous for apps in production. We should add an editor method to override that behavior: editor.getMaxNormalizationIterations(dirtyPaths) so we can choose to reuse dirtyPaths or a local logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants