You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The amount of max normalization iterations isn't enough for some large content in my app. It is set here as the number of dirty paths multiplied by 42. There's a comment next to the code that says //HACK: better way?. I'd love to learn more if bumping this multiplier is okay.
Solution
Either allow that 42 number to be configurable by the user, or increase that number. Locally, I've increased it to 100 and it fixes our use cases.
Alternatives
Open to suggestions!
Context
PR will be incoming.
I am curious if there are risks or concerns associated with this increase. I've applied the fix locally on my app and it fixes the issues. Thank you for your input!
The text was updated successfully, but these errors were encountered:
I think that error is generally dangerous for apps in production. We should add an editor method to override that behavior: editor.getMaxNormalizationIterations(dirtyPaths) so we can choose to reuse dirtyPaths or a local logic
Problem
The amount of max normalization iterations isn't enough for some large content in my app. It is set here as the number of dirty paths multiplied by 42. There's a comment next to the code that says
//HACK: better way?
. I'd love to learn more if bumping this multiplier is okay.Solution
Either allow that
42
number to be configurable by the user, or increase that number. Locally, I've increased it to 100 and it fixes our use cases.Alternatives
Open to suggestions!
Context
PR will be incoming.
I am curious if there are risks or concerns associated with this increase. I've applied the fix locally on my app and it fixes the issues. Thank you for your input!
The text was updated successfully, but these errors were encountered: