Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize behavior of insert* methods #5414

Closed
dylans opened this issue May 5, 2023 · 0 comments · Fixed by #5415
Closed

Harmonize behavior of insert* methods #5414

dylans opened this issue May 5, 2023 · 0 comments · Fixed by #5415

Comments

@dylans
Copy link
Collaborator

dylans commented May 5, 2023

We currently have a fair bit of inconsistency and confusion with our insert methods, whether they are the version from Editor or Transforms.

I think we should make sure the following happens:

  • All insert methods should optionally accept a location
  • If no location is provided and there's no selection within the editor, we should either throw or insert at a consistent location (start or end of the document?)
  • Update the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant