Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use negative integer for from duration #30

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use negative integer for from duration #30

wants to merge 4 commits into from

Conversation

comp615
Copy link
Contributor

@comp615 comp615 commented Nov 15, 2022

Closes #29. According to Apollo support, the from field should be sent in negative seconds when using a relative timestamp. This updates the value we send

Updated dependencies

Include a list of newly added or updated dependencies

Future work

N/A

Checklist

  • Have you fully tested your PR locally?
  • [ X ] Have you written thorough tests for your work?
  • [ X ] Have you made a CHANGELOG entry?

@comp615
Copy link
Contributor Author

comp615 commented Nov 15, 2022

As before, I don't really know how to test Github actions locally so this is somewhat untested...

@comp615
Copy link
Contributor Author

comp615 commented Dec 9, 2022

Finally came back and tested this locally using a fork:
uses: comp615/apollo-schema-check-action@negative_from_test. Verified that with the fix, the time ranges correctly show up and thus should detect issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid Timestamp returned for check in some cases
1 participant
@comp615