Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture-in-Picture support, currently does not float. #1220

Open
puccaso opened this issue Mar 20, 2022 · 3 comments
Open

Picture-in-Picture support, currently does not float. #1220

puccaso opened this issue Mar 20, 2022 · 3 comments

Comments

@puccaso
Copy link

puccaso commented Mar 20, 2022

Describe the bug
Picture in picture does not float.

Applications:
What applications are involved? same issue with chrome or brave.
floating: (
{
id = "com.brave.Browser";
"window-titles" = (
);
}
)

To Reproduce
Steps to reproduce the behavior:
enable picture-in-picture (PIP) via browser

Expected behavior
PIP should float

Screenshots
If applicable, add screenshots to help explain your problem.

Versions:

  • macOS: OS version: Version 12.3 (Build 21E230)
  • Amethyst: Version: 0.15.6 (93)

Debug Info

 ~ /Applications/Amethyst.app/Contents/MacOS/Amethyst --debug-info
Version: 0.15.6 (93)

OS version: Version 12.3 (Build 21E230)

Screens:
	(0.0, 0.0, 3200.0, 1800.0) [(0.0, 0.0, 3200.0, 1800.0)]

Configuration:
window-resize-step: 10
debug-layout-info: 1
screen-padding-top: 10
window-minimum-width: 500
screen-padding-right: 10
new-windows-to-main: 0
window-minimum-height: 500
screen-padding-left: 10
follow-space-thrown-windows: 1
ignore-menu-bar: 0
floating-is-blacklist: 1
window-margins: 1
mouse-follows-focus: 0
mod2: (
    option,
    shift,
    control
)
screen-padding-bottom: 10
mouse-resizes-windows: 1
smart-window-margins: 1
restore-layouts-on-launch: 1
use-canary-build: 1
enables-layout-hud: 1
window-margin-size: 10
floating: (
        {
        id = "com.brave.Browser";
        "window-titles" =         (
            "Opening.*"
        );
    }
)
focus-follows-mouse: 0
mouse-swaps-windows: 1
float-small-windows: 1
mod1: (
    option,
    shift
)
enables-layout-hud-on-space-change: 1
layouts: (
    bsp,
    "two-pane",
    "middle-wide",
    "3column-right",
    "3column-left",
    "widescreen-tall-right"
)

Additional context
Add any other context about the problem here.

the current floating options in the GUI require a title, and while using Regex for things like "Opening.*" work for certain apps, not all browsers don't use a separate titling format for videos playing PIP.

@ianyh
Copy link
Owner

ianyh commented May 8, 2022

I think the issue is more likely that the PiP window is not a part of the application–Brave, in this case–but rather some system level thing.

@sachinsid
Copy link

sachinsid commented Jun 14, 2022

FWIW, I have been able to decipher the window names of (most) PiP videos playing on the Edge Browser on macOS as having the window title “Picture in Picture” using the following Apple script:

tell application "System Events" to get the (title, id) of every window of (every process whose visible is true)

Add that title to the floating Window Title Restrictions. Works for me on YouTube and other sites where PiP is supported. Not tested on other browsers yet

@joech4n
Copy link

joech4n commented Oct 30, 2022

I've also been able to identify the title of the PIP window by using Mission Control (for application windows).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants