Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Config Example #1384

Closed
Indyandie opened this issue Jan 21, 2023 · 10 comments
Closed

Expand Config Example #1384

Indyandie opened this issue Jan 21, 2023 · 10 comments

Comments

@Indyandie
Copy link

Include all configuration options in .amethyst.sample.yml.

  • Configuration Keys
  • Command Keys
  • Shortcuts (Not sure if this is supported at the moment.)
@ianyh
Copy link
Owner

ianyh commented Jan 21, 2023

Duplicate of #1321

@ianyh ianyh marked this as a duplicate of #1321 Jan 21, 2023
@ianyh ianyh closed this as not planned Won't fix, can't repro, duplicate, stale Jan 21, 2023
@Indyandie
Copy link
Author

Apologies @ianyh! 😅 I should've checked before submitting a new ticket. Does the config file support shortcuts?

@ianyh
Copy link
Owner

ianyh commented Jan 21, 2023

No worries! Yes, it should. There was a bug in 0.16.0 that broke them, but it should be fixed in 0.16.1.

@Indyandie
Copy link
Author

Is this the correct format for shortcuts?

# switch to the two-pane layout
two-pane:
  mod: mod1
  key: s

@jabkoo
Copy link
Contributor

jabkoo commented Feb 3, 2023

@Indyandie I was trying to discover it too and I found this example in Amethyst/default.amethyst file:

"select-wide-layout": {
    "mod": "mod1",
    "key": "s"
}

So you can do the same in YAML file for Two Pane layout with:

select-two-pane-layout:
    mod: mod1
    key: s

@Indyandie
Copy link
Author

@jabkoo Thank so much! I'll give this a try as soon as I get a chance.

@Indyandie
Copy link
Author

@jabkoo that's the right format!

But for some reason I couldn't set two pane to select using the s key. What is more puzzling, is that s key works with the tall layout but t key didn't. 😵

I ended up using number keys to select the layouts that I wanted.

select-two-pane-layout:
  mod: mod1
  key: "2"

select-fullscreen-layout:
  mod: mod1
  key: "7"

select-tall-layout:
  mod: mod1
  key: "8"
``

@ianyh
Copy link
Owner

ianyh commented Feb 12, 2023

mod1+s appears to be the default command for select-wide-layout. That is probably colliding with it. The config file parsing should probably be changed to override it, though.

@Indyandie
Copy link
Author

That also explains why mod1+t didn't work either since the default is toggle float.

@ianyh
Copy link
Owner

ianyh commented Feb 12, 2023

Could you actually open a new issue to track that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants