"Automatically float all applications except those listed" breaks the functionality

[Morgy93]

Describe the bug
The application "breaks" and does not update windows anymore the moment I change Automatically float applications listed to Automatically float all applications except those listed and restart Amethyst.

Applications:
Does not matter, none are working.

To Reproduce
Install Amethyst and change Automatically float applications listed to Automatically float all applications except those listed.

Expected behavior
Basically, I expect nothing to happen, since the list of applications to exclude is empty. So, application should work like before.

Screenshots

Versions:

• macOS: Ventura 13.1
• Amethyst: 0.17.0

Debug Info

Version: 0.17.0 (97)

OS version: Version 13.1 (Build 22C65)

Screens:
	(0.0, 0.0, 3840.0, 1600.0) [(0.0, 0.0, 3840.0, 1600.0)]
	(-1728.0, 483.0, 1728.0, 1117.0) [(-1728.0, 0.0, 1728.0, 1117.0)]
	(3840.0, -92.0, 3008.0, 1692.0) [(3840.0, 0.0, 3008.0, 1692.0)]

Configuration:
window-minimum-height: 0
layouts: (
    tall,
    wide,
    fullscreen,
    column
)
focus-follows-mouse: 0
window-minimum-width: 0
mod1: (
    option,
    shift
)
mouse-resizes-windows: 1
mod2: (
    option,
    shift,
    control
)
window-margins: 0
use-canary-build: 0
follow-space-thrown-windows: 0
mouse-swaps-windows: 1
ignore-menu-bar: 0
screen-padding-bottom: 0
debug-layout-info: 0
window-max-count: 0
enables-layout-hud: 1
window-margin-size: 0
enables-layout-hud-on-space-change: 1
screen-padding-left: 0
restore-layouts-on-launch: 1
screen-padding-right: 0
floating-is-blacklist: 1
screen-padding-top: 0
mouse-follows-focus: 1
floating: (
)
window-resize-step: 5
new-windows-to-main: 0
float-small-windows: 0

Additional context
I thought it's related to #1341 (comment) but that seems not to be the case. Therefore, I opened another issue.

[ianyh]

That is the expected behavior. That options floats all applications by default and you provide exceptions that should be tiled. As opposed to the first option which floats no applications by default and you provide exceptions that should not be tiled.

[Morgy93]

That is the expected behavior. That options floats all applications by default and you provide exceptions that should be tiled. As opposed to the first option which floats no applications by default and you provide exceptions that should not be tiled.

Oh my gosh, who came up with that naming then? Completely confusing 😅 It's like ... twisted 😕

[ianyh]

I'm open to suggestions on wording.

[Morgy93]

I'm open to suggestions on wording.

Just switch the options:

Automatically float applications listed:
I'd expect to ONLY float applications that are added to the list.

Automatically float all applications except those listed:
I'd expect to float ALL applications except those added to the list.

That means Automatically float all applications except those listed should be the default option, if changed like above.

[ianyh]

Those are the options. You haven't changed anything, and switching the default would break tiling by default.

[Morgy93]

Those are the options. You haven't changed anything, and switching the default would break tiling by default.

You confuse me even more, that does not fit to your first answer and the current behavior of the app 😅

Currently:
Automatically float applications listed floats ALL applications EXCEPT those listed
Automatically float all applications except those listed floats NO applications EXCEPT those listed

[ianyh]

I'm struggling with where the confusion is. That is not what the logic currently is. I just tested it to confirm I wasn't going insane.

[ianyh]

This is my first message.

That is the expected behavior. That options floats all applications by default and you provide exceptions that should be tiled. As opposed to the first option which floats no applications by default and you provide exceptions that should not be tiled.

The antecedent of "that options" (sorry for the typo) is the option you have highlighted in your screenshot; i.e., "Automatically float all applications except those listed." The antecedent of "the first option" is the first option in the drop down list that you do not show as selected; i.e., "Automatically float applications listed."

[Morgy93]

I'm struggling with where the confusion is. That is not what the logic currently is. I just tested it to confirm I wasn't going insane.

Maybe it's just broken for me then? 😅

This is my current configuration:

And it floats ALL applications, except spotify in this case, which is in the list.

But I'd expect this behavior for the other setting (Automatically float all applications except those listed)

[ianyh]

That is not what was in your original screenshot. Can you relaunch and then provide the output of the --debug-info call again?

[Morgy93]

That is not what was in your screenshot. Can you relaunch and then provide the output of the --debug-info call again?

You probably just misinterpreted my screenshot 😁
The highlighted option is the one I was using.
I just opened the selection box to be more precise (maybe that one went wrong 😅)

Version: 0.17.0 (97)

OS version: Version 13.1 (Build 22C65)

Screens:
	(0.0, 0.0, 3840.0, 1600.0) [(0.0, 0.0, 3840.0, 1600.0)]
	(-1728.0, 483.0, 1728.0, 1117.0) [(-1728.0, 0.0, 1728.0, 1117.0)]
	(3840.0, -92.0, 3008.0, 1692.0) [(3840.0, 0.0, 3008.0, 1692.0)]

Configuration:
screen-padding-top: 0
window-minimum-height: 0
window-margins: 0
mod1: (
    option,
    shift
)
screen-padding-left: 0
enables-layout-hud-on-space-change: 1
window-minimum-width: 0
window-resize-step: 5
mod2: (
    option,
    shift,
    control
)
use-canary-build: 0
debug-layout-info: 0
mouse-resizes-windows: 1
restore-layouts-on-launch: 1
screen-padding-right: 0
follow-space-thrown-windows: 0
float-small-windows: 0
window-max-count: 0
ignore-menu-bar: 0
screen-padding-bottom: 0
window-margin-size: 0
layouts: (
    tall,
    wide,
    fullscreen,
    column
)
focus-follows-mouse: 0
new-windows-to-main: 0
floating: (
        {
        id = "com.spotify.client";
        "window-titles" =         (
        );
    }
)
mouse-follows-focus: 1
floating-is-blacklist: 1
enables-layout-hud: 1
mouse-swaps-windows: 1

[ianyh]

Could you try installing 0.18.0b2? https://github.com/ianyh/Amethyst/releases/tag/v0.18.0b2

[Morgy93]

No change, same behavior:

Version: 0.18.0b2 (99)

OS version: Version 13.1 (Build 22C65)

Screens:
	(0.0, 0.0, 3840.0, 1600.0) [(0.0, 0.0, 3840.0, 1600.0)]
	(-1728.0, 483.0, 1728.0, 1117.0) [(-1728.0, 0.0, 1728.0, 1117.0)]
	(3840.0, -92.0, 3008.0, 1692.0) [(3840.0, 0.0, 3008.0, 1692.0)]

Configuration:
enables-layout-hud: 1
window-minimum-height: 0
float-small-windows: 0
mod1: (
    option,
    shift
)
enables-layout-hud-on-space-change: 1
mod2: (
    option,
    shift,
    control
)
mouse-resizes-windows: 1
ignore-menu-bar: 0
window-minimum-width: 0
restore-layouts-on-launch: 1
mouse-swaps-windows: 1
floating: (
        {
        id = "com.spotify.client";
        "window-titles" =         (
        );
    }
)
use-canary-build: 1
floating-is-blacklist: 1
layouts: (
    tall,
    wide,
    fullscreen,
    column
)
screen-padding-bottom: 0
window-margin-size: 0
follow-space-thrown-windows: 0
screen-padding-top: 0
mouse-follows-focus: 1
window-max-count: 0
screen-padding-left: 0
new-windows-to-main: 0
window-resize-step: 5
window-margins: 0
screen-padding-right: 0
debug-layout-info: 0
focus-follows-mouse: 0