Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layouts should be per-Space as well as per-Screen #2

Closed
ianyh opened this issue May 26, 2013 · 8 comments
Closed

Layouts should be per-Space as well as per-Screen #2

ianyh opened this issue May 26, 2013 · 8 comments

Comments

@ianyh
Copy link
Owner

ianyh commented May 26, 2013

No description provided.

@ianyh
Copy link
Owner Author

ianyh commented Jun 10, 2013

The APIs for identifying spaces are private, but it may be possible to heuristically fingerprint a space via its visible windows with -[NSWindow windowNumbersWithOptions] or something like that. Have to figure out the edge cases (e.g, what if we don't catch a window creation in an off space and thus lose our key?).

@dhgwilliam
Copy link
Contributor

@ianyh this doesn't work consistently for me, although it might be because my desktops tend to be identical. e.g.:
S1: [ 'Google Chrome', 'KeepassX' ]
S2: [ 'Google Chrome', 'Google Chrome', 'KeepassX' ]
S3: [ 'Google Chrome', 'iTerm2', 'Google Chrome', 'KeepassX' ]
S4: (de facto float space) [ 'Hibari', 'Adium', 'KeepassX' ]
S5: [ 'Google Chrome' ]

Ideas?

@ianyh
Copy link
Owner Author

ianyh commented Aug 26, 2013

Hm. Does KeepassX persist across spaces? It's possible that would confuse the logic of determining which space we're in. I'll download it and give it a try.

@ianyh ianyh reopened this Aug 26, 2013
@dhgwilliam
Copy link
Contributor

Not naturally, no. I have manually set it to be on All Spaces. I mostly keep it hidden, but sometimes I forget to hide it. I do the same thing wth NValt.

@ianyh ianyh closed this as completed in 487cab1 Sep 5, 2013
@ianyh
Copy link
Owner Author

ianyh commented Sep 5, 2013

@dhgwilliam I think this should work. I tested it with keepassx across all spaces. Let me know if you run into trouble.

@dhgwilliam
Copy link
Contributor

@ianyh it appears to improve space detection, but it introduces a significant performance issue. amethyst is unresponsive for several seconds after changing spaces.

@ianyh
Copy link
Owner Author

ianyh commented Sep 5, 2013

Hm. I haven't noticed any slowdown on my end. It's possible I just have significantly less windows than you do. I'll look into it.

@ianyh
Copy link
Owner Author

ianyh commented Sep 5, 2013

Opened #46 to track performance issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants