Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center the window when failing to assign a larger window frame #437

Open
Qusic opened this issue May 5, 2016 · 3 comments
Open

Center the window when failing to assign a larger window frame #437

Qusic opened this issue May 5, 2016 · 3 comments

Comments

@Qusic
Copy link

Qusic commented May 5, 2016

When I am using the fullscreen layout and open System Preferences, it is put at the top-right corner of my screen. It doesn't seem good especially on a large screen.

I justed looked into a little and found this method: https://github.com/ianyh/Amethyst/blob/development/Amethyst/ReflowOperation.swift#L67-L97

What I am considering is that, when it fails to assign the window a larger frame(when the max frame of the window is smaller than what we want), we center that window within the expected frame(fullscreen frame in this example). So that System Preferences would appear in the center of screen in fullscreen layout.

I think it should be a good enhancement. Or did I overlook any issues it would cause?

Trello Card

@ianyh
Copy link
Owner

ianyh commented May 5, 2016

That actually seems like a pretty good idea to me.

@slippycheeze
Copy link

FWIW, I'd love this too. I'd prefer that the placement was horizontally centered on the current screen, and ~ 10 percent down from the top by default, rather than centered vertically. That puts it much more in the core "attention" zone, IMO.

@ianfixes
Copy link
Contributor

ianfixes commented Sep 4, 2018

The link to the method in the issue description appears to have rotted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants