Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EXPRES interface #9

Open
5 of 6 tasks
Kamuish opened this issue May 4, 2022 · 5 comments
Open
5 of 6 tasks

Adding EXPRES interface #9

Kamuish opened this issue May 4, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@Kamuish
Copy link
Member

Kamuish commented May 4, 2022

  • S2D spectrum
  • sub-Instruments
  • KWs of interest
  • Observatory properties for telfit
  • Load telluric mask
  • Avoid multiple telluric removal applications
@Kamuish Kamuish added the enhancement New feature or request label May 4, 2022
@Kamuish
Copy link
Member Author

Kamuish commented May 4, 2022

Missing KWs:

  • BERV (achromatic)
  • water content + ambient temperature (for telfit)

No need of implementing telfit for now. We can live with SELENITE, instead opening new issue to enhance the EXPRESS implementation

@Kamuish
Copy link
Member Author

Kamuish commented May 4, 2022

The SELENITE telluric model has negative values , which leads to numerical issues (near zero) when trying to divide \frac{spectrum}{model}

image

@Kamuish
Copy link
Member Author

Kamuish commented May 16, 2022

The SELENITE model is for removal, not correction... Not a good idea to remove different wavelength regions in each observation, selecting worst night of all to use as "reference" (similarly to current SBART approaches to tellurics). Needs to allow bypassing the creation of transmittance spectrum in the two templates

@Kamuish
Copy link
Member Author

Kamuish commented May 17, 2022

First skeleton implementation is complete.
To be tested:

  • Data loading of multiple observations + CCF access checks
  • Test creation of Telluric Template
  • Apply RV extractions

Important note 1: Due to the spectrum being normalized we will, most likely, run into numerical issues.
Important note 2: Due to the spectrum being normalized the Stellar Template creation will break

@Kamuish
Copy link
Member Author

Kamuish commented May 17, 2022

From the docs, we might be able to retrieve original counts:

blaze gives the counts of the median flat exposure that the extractions were done with respect to. Multiplying the spectrum by this blaze will return the original counts for each pixel. These counts, which are presumed Poisson distributed, provide the best measure of SNR for the exposure. Note that because this is simply a median flat exposure, it may contain some detector defects that would otherwise be flat-fielded out in the extracted exposures through the flat-relative extraction. Users are encouraged to fit a smooth function to this blaze before multiplying by the extracted spectrum to recover true counts.

@j-faria j-faria changed the title Adding EXPRESS interface Adding EXPRES interface May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant