Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request: fix http Client.Timeout issue #62

Merged
merged 3 commits into from Mar 27, 2018
Merged

request: fix http Client.Timeout issue #62

merged 3 commits into from Mar 27, 2018

Conversation

joekyo
Copy link
Contributor

@joekyo joekyo commented Mar 26, 2018

No description provided.

@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #62 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   85.26%   85.34%   +0.07%     
==========================================
  Files          14       14              
  Lines         760      764       +4     
==========================================
+ Hits          648      652       +4     
  Misses         95       95              
  Partials       17       17
Impacted Files Coverage Δ
extractors/youtube.go 94.66% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3a9e23...8dc3613. Read the comment docs.

@johntaiii
Copy link

Default timeout would cause request/response object not release.

Copy link
Owner

@iawia002 iawia002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @joekyo, just one small problem

README.md Outdated
@@ -311,12 +311,6 @@ Tumblr | <https://www.tumblr.com> | ✓ | ✓ | |
Vimeo | <https://vimeo.com> | ✓ | | |


## Known issues
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This headline needs to be retained, you can delete it's contents

@iawia002
Copy link
Owner

thanks for both of you!

A suggestion, next time, you can split those two commits into two PRs.

@iawia002 iawia002 merged commit 5a7df3f into iawia002:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants