Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added highlight for the row with the current local time #15

Merged
merged 2 commits into from May 13, 2021
Merged

Added highlight for the row with the current local time #15

merged 2 commits into from May 13, 2021

Conversation

Badboy-16
Copy link
Contributor

Fixed #12

Using the text formatting tool in rich, I added some code to highlight the row with current hour in red. Please let me know if other colours/formats are preferred and I may change the highlight. :)

Copy link
Owner

@ibLeDy ibLeDy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions, but your contribution looks good!

timezone_converter/comparison_view.py Outdated Show resolved Hide resolved
- Used a default value and check if the hour matches and then change the value
- Used f-strings
- Changed the highlighed colour to blue
@ibLeDy
Copy link
Owner

ibLeDy commented May 13, 2021

Thanks for your contribution, I will publish a new release to PyPi with this changes!

@ibLeDy ibLeDy merged commit 93e4242 into ibLeDy:main May 13, 2021
@Badboy-16 Badboy-16 deleted the 12 branch May 14, 2021 00:52
@ibLeDy ibLeDy added this to Done in Timezone Converter May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Highlight row with the current local time
2 participants