Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a search option to the cli #25

Closed
ibLeDy opened this issue Oct 2, 2021 · 4 comments · Fixed by #27
Closed

Add a search option to the cli #25

ibLeDy opened this issue Oct 2, 2021 · 4 comments · Fixed by #27
Assignees
Labels
enhancement New feature or request hacktoberfest Hacktoberfest 2021
Milestone

Comments

@ibLeDy
Copy link
Owner

ibLeDy commented Oct 2, 2021

This would add a --search option to the cli, which can be used to search timezones by name.

Examples:

$ timezone-converter --search "new york"
Found 1 timezone: "new_york"
$ timezone-converter --search mad
Found 2 timezones: "madeira", "madrid"
@ibLeDy ibLeDy added enhancement New feature or request hacktoberfest Hacktoberfest 2021 labels Oct 2, 2021
@ibLeDy ibLeDy added this to the v1.0.0 milestone Oct 2, 2021
@ibLeDy ibLeDy added this to To do in Timezone Converter via automation Oct 2, 2021
@26tanishabanik
Copy link

@ibLeDy I would like to work on this issue, kindly assign this issue to me.

@ibLeDy
Copy link
Owner Author

ibLeDy commented Oct 2, 2021

@26tanishabanik So sorry, this issue is already being worked on by @drzcola, but seems like I forgot to assign 1 it, my bad.

With that said, you're free to take any other issue that is unassigned.

Footnotes

  1. Seems like I can't assign him, as he is not a participant of the Issue

@drzcola
Copy link
Contributor

drzcola commented Oct 3, 2021

@ibLeDy we have the "--search" as argument. But "-s" is already used for single, so we can either keep it just as "--search" or use another one for the short version of the argument.

@ibLeDy
Copy link
Owner Author

ibLeDy commented Oct 3, 2021

I think we can just use --search and -S as a short version

@ibLeDy ibLeDy closed this as completed in #27 Oct 4, 2021
Timezone Converter automation moved this from To do to Done Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Hacktoberfest 2021
Projects
Development

Successfully merging a pull request may close this issue.

3 participants