Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output close matches when the timezone argument is not correct #4

Closed
ibLeDy opened this issue Nov 19, 2020 · 3 comments · Fixed by #26
Closed

Output close matches when the timezone argument is not correct #4

ibLeDy opened this issue Nov 19, 2020 · 3 comments · Fixed by #26
Assignees
@drzcola
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest 2021
Projects
Timezone Converter
Milestone
v1.0.0

Comments

@ibLeDy
Copy link
Owner

ibLeDy commented Nov 19, 2020 •
edited

When the user inputs a timezone that is not in the list, we should fuzzy search for similar ones to offer a suggestion.

We can also have a fuzzy search capability in case the --list option is not useful enough
@ibLeDy ibLeDy added the enhancement New feature or request label Nov 19, 2020
@ibLeDy ibLeDy changed the title Add search capabilities for cities Search capabilities for cities Nov 24, 2020
@ibLeDy ibLeDy changed the title Search capabilities for cities Search/recommend capabilities Feb 6, 2021
@ibLeDy ibLeDy added this to the v1.0.0 milestone Feb 6, 2021
@ibLeDy ibLeDy added this to To do in Timezone Converter May 15, 2021
@ibLeDy
Copy link
Owner Author

ibLeDy commented May 22, 2021

Seems like this can be done in an easy manner, even without external dependencies, as per https://twitter.com/pybites/status/1396102910627487749

Seems like django is using it for manage.py too, so we can learn from their implementation: https://github.com/django/django/pull/9703/files

@ibLeDy ibLeDy added the good first issue Good for newcomers label May 23, 2021
@ibLeDy ibLeDy added the hacktoberfest Hacktoberfest 2021 label Sep 25, 2021
@drzcola
Copy link
Contributor

drzcola commented Oct 2, 2021

Hello @ibLeDy,

I'd like to give a hand with this.

@ibLeDy
Copy link
Owner Author

ibLeDy commented Oct 2, 2021

Sure, I'll assign the issue to you

@ibLeDy ibLeDy changed the title Search/recommend capabilities Output close matches when the timezone argument is not correct Oct 2, 2021
@drzcola drzcola mentioned this issue Oct 2, 2021
Merged
@ibLeDy ibLeDy closed this as completed in #26 Oct 2, 2021
Timezone Converter automation moved this from To do to Done Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drzcola drzcola

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest 2021
Projects
Timezone Converter
  
Done
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

display closest matches (if any) for incorrect timezone drzcola/timezone-converter
2 participants
@drzcola @ibLeDy