Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong timezone for GMT+-X conversion #47

Open
Edwardhk opened this issue Nov 24, 2022 · 1 comment
Open

Wrong timezone for GMT+-X conversion #47

Edwardhk opened this issue Nov 24, 2022 · 1 comment
Labels
help wanted Extra attention is needed
Milestone

Comments

@Edwardhk
Copy link

Edwardhk commented Nov 24, 2022

Issue:

The timezone output of the gmt+x and gmt-x seems to be swapped.
For the reference, Hong Kong is in GMT+8.

Step to reproduce:

$ timezone-converter --version
timezone-converter 0.12.1

$ timezone-converter hong_kong gmt-5 gmt+5

┏━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┓
┃      LOCAL       ┃  ASIA/HONG_KONG  ┃    ETC/GMT-5     ┃    ETC/GMT+5     ┃
┡━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━┩
│ 2022-11-24 00:00 │ 2022-11-24 00:00 │ 2022-11-23 21:00 │ 2022-11-23 11:00 │
│ 2022-11-24 01:00 │ 2022-11-24 01:00 │ 2022-11-23 22:00 │ 2022-11-23 12:00 │
│ 2022-11-24 02:00 │ 2022-11-24 02:00 │ 2022-11-23 23:00 │ 2022-11-23 13:00 │
│ 2022-11-24 03:00 │ 2022-11-24 03:00 │ 2022-11-24 00:00 │ 2022-11-23 14:00 │
│ 2022-11-24 04:00 │ 2022-11-24 04:00 │ 2022-11-24 01:00 │ 2022-11-23 15:00 │
...
@ibLeDy
Copy link
Owner

ibLeDy commented Mar 1, 2023

Sorry, I don't have free time to review this issue right now. Feel free to submit a PR if you want to tackle the issue tho!

@ibLeDy ibLeDy added this to the v1.0.0 milestone Mar 1, 2023
@ibLeDy ibLeDy added this to To do in Timezone Converter via automation Mar 1, 2023
@ibLeDy ibLeDy added the help wanted Extra attention is needed label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Development

No branches or pull requests

2 participants