Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss the keyboard automatically #28

Open
JakeLin opened this issue Jan 13, 2016 · 4 comments
Open

Dismiss the keyboard automatically #28

JakeLin opened this issue Jan 13, 2016 · 4 comments

Comments

@JakeLin
Copy link
Member

JakeLin commented Jan 13, 2016

Add one @IBInspectable property like autoDismissKeyboard to AnimatableViewController.

@JakeLin JakeLin added this to the v3 milestone Feb 13, 2016
@JakeLin JakeLin modified the milestones: v3, v4 Feb 13, 2016
@tbaranes
Copy link
Member

What's the idea behind that feature? Hiding the keyboard when a viewController is disappearing?

@JakeLin
Copy link
Member Author

JakeLin commented Jun 25, 2016

For example, if we have some UITextField and UITextView in a ViewCotroller, once the keyboard is up, we need to write some code to dismiss it manually. How about we can automatically dismiss the keyboard when the user taps out of the UITextField. That is a small feature on top of my head 😊

@tbaranes
Copy link
Member

tbaranes commented Jun 25, 2016

I can understand the feature, but won't it be hard to make it customisable with IB if it's just a boolean (well, if you mean that)? Maybe it could be the same as AnimatableType, and the others, a string property with different options:

  • CloseWhenDisappear (I really find this one useful 😆)
  • TapToClose
  • Others?

To be more flexible, we can do it like borderSide and support multiple options at the same time.

@JakeLin
Copy link
Member Author

JakeLin commented Jun 27, 2016

@tbaranes I think an enum like borderSide will be extendable, good idea 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants