Cython wrapper build fix

[AlexJoz]

Hello.
Seems user keys works only for private root repos, so I managed to make it work with user credentials encrypted via travis. Is it possible to make the dedicated user for that purpose?

And the second question, why shouldn't we use Hunter? Maybe we can add eigen via ExternalProject_Add in cmake or smth similar specially for travis build, but does it worth it? Or you just want to cut out Hunter away?

[ibayer]

Is it possible to make the dedicated user for that purpose?

That's a good idea, I have already created one some time ago for this purpose.
I'll send you the credentials via upwork.

And the second question, why shouldn't we use Hunter?

Hunter is a huge help in managing dependencies but not having any dependencies is even better.
The part of the project relevant for the python wrapper (see README Build only fastFM lib) has only EIGEN as dependency (which is header only) and we could for example include EIGEN as submodule or external project (whatever is simpler).

I think dropping Hunter for this part simplifies things without any real downside. Simplicity is very important, people need to understand the project setup quickly to contribute improvements to the project.

[AlexJoz]

Got the credentials for user, but i'm not allowed to make a environment variable in your travis settings.

p.s. if it's hard with travis access rights, I can send you the details, so you add it by yourself (this wont take much time - just apply the command)

[ibayer]

@AlexJoz
Did you check if this works on your fork (you should be able to change travis settings there)?

Yes, please send me step by step instructions (or a pointer to relevant doc) when you are confident that this will work (I have unsuccessfully tried a few things before) and I will do the changes.

[AlexJoz]

Yep, i checked it.
I sent a small instruction as upwork message..

[ibayer]

Probably need to be changed back or?
You can create new branch in my repo and push you changes there.

[AlexJoz]

yep, i'll fix it back, after i can test with your repo

[ibayer]

I have added the CI_TOKEN.

fatal: Authentication failed for 'https://@github.com/AlexJoz/fastFM-core2.git/'

[AlexJoz]

oh, ok. thnx. I'll check )

[AlexJoz]

Hm, we cannot check this in PR anyway, coz https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

p.s. i have no rights to push to this repo, to check in branch...

[ibayer]

Makes sense I have given you access rights. You can push changes to cython-wrapper branch or I merge this PR first.

[ibayer]

@AlexJoz Can we close this PR?

[AlexJoz]

yep)