Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure reroll counts are tracked properly #13

Closed
IBBoard opened this issue Oct 3, 2021 · 1 comment
Closed

Make sure reroll counts are tracked properly #13

IBBoard opened this issue Oct 3, 2021 · 1 comment

Comments

@IBBoard
Copy link
Owner

IBBoard commented Oct 3, 2021

Following #6, it looks like we are adding a leader reroll every kickoff. That's fine if it's a quiet match and the game only has one touchdown in the last turn of each half, but quick teams can score quicker and leaders shouldn't get another reroll until the next half.
IBBoard added a commit that referenced this issue Oct 3, 2021
@IBBoard
Re #13: Track usage of Leader skill
3ac5113 
* Don't re-add leader reroll after use
* Track which leaders have been used
* Reset at halftime (not each kickoff!)
IBBoard added a commit that referenced this issue Oct 3, 2021
@IBBoard
Re #13: Separate leader reroll from team reroll
fc0b587 
By swapping from a public field to a property we can pretend we have
a count including the leader reroll, but we can internally track actual
rerolls without having to track whether to remove a leader reroll
next setup.

This resolves an issue with us regenerating rerolls every setup
rather than every half
IBBoard added a commit that referenced this issue Oct 3, 2021
@IBBoard
Re #13: Check leader rerolls in block reroll
ec691e8 
Changes to separate team and leader rerolls mean that blocking
needs to check which type it is using as well.
@IBBoard
Copy link
Owner Author

IBBoard commented Oct 3, 2021

Seem to be tracking everything now - leader doesn't carry over, leader can't be applied twice, and team rerolls only regenerate at half-time.

@IBBoard IBBoard closed this as completed Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IBBoard