Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup mismatch leads to armour value roll validation failure #5

Open
IBBoard opened this issue Jul 10, 2021 · 3 comments
Open

Setup mismatch leads to armour value roll validation failure #5

IBBoard opened this issue Jul 10, 2021 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@IBBoard
Copy link
Owner

IBBoard commented Jul 10, 2021

We get ValueError: Expected ArmourValueRollEntry for TeamType.HOME #4 but got TeamType.HOME #5 from Replay_2020-08-23_10-04-41.db because there's a target player command for data [1, 7, 0, 2, 255, 255, 0, 0, 1, 0, 0, 0] (player index 2, which is player number 4) but the target space command has data [1, 7, 4, 0, 26, 0, 0, 0, 4, 10, 0, 0] and player index 3 (number 5) is in that space.

Also, this isn't picked up until the armour roll stage. We should be able to check the space occupant before we get to armour rolls.

@IBBoard IBBoard added bug Something isn't working help wanted Extra attention is needed labels Jul 10, 2021
@IBBoard
Copy link
Owner Author

IBBoard commented Jul 11, 2021

This appears to be a setup issue.

Board shows:

  • 1, 10 and 12 on the front row
  • 6, 4, 5 and 7 in row 10
  • 2 on the left in row 9
  • 3 on the right of row 7
  • 8 on the left of row 6

Replay shows:

  • 1, 11 and 2 on the front row
  • 7, 5, 6 and 8 in row 10
  • 16 and 10 in the wings on row 9
  • 4 on the right of row 7
  • 9 on the left of row 6

So only one player is in the correct position (number 1) and one player is missing (right wing)

@IBBoard IBBoard changed the title Investigate blitz target mismatch Setup mismatch leads to armour value roll validation failure Jul 11, 2021
@IBBoard
Copy link
Owner Author

IBBoard commented Jul 11, 2021

The mapping of index to player number must be wrong, because the target is player index 2, so as far as the validation is concerned then everything is correct.

@IBBoard
Copy link
Owner Author

IBBoard commented Jul 11, 2021

A similar problem in Replay_2020-08-30_10-04-37.db seems to be causing a validation failure when we expect block dice but have a Wild Animal in the logs (because the player with that index isn't the rat ogre, but the log clearly says the rat ogre blitzed). And again it seems to be tied to index issues that mean that players are out of position (because the non-rat ogre doesn't make any moves of more than one space).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant