Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangs in gvim #11

Closed
gauteh opened this issue Feb 12, 2019 · 7 comments
Closed

Hangs in gvim #11

gauteh opened this issue Feb 12, 2019 · 7 comments

Comments

@gauteh
Copy link

gauteh commented Feb 12, 2019

Is the plugin supposed to work in gvim? tig works fine if I run it with :terminal tig.

@iberianpig
Copy link
Owner

It doesn't support on gvim.
Could you make PR if you can?

@gauteh
Copy link
Author

gauteh commented Feb 12, 2019

Ok, I dont have the chance at the moment.

@gauteh gauteh closed this as completed Feb 12, 2019
@kiryph
Copy link

kiryph commented Mar 27, 2019

It does not work in most recent release (snapshot 155) of MacVim with +terminal either.

@iberianpig Can you shortly mention what code parts have to be changed?

This is not obvious to me.

@iberianpig iberianpig reopened this Mar 28, 2019
@iberianpig
Copy link
Owner

If you extend for MacVim, you may check following codes written for NeoVim.

@kiryph
Copy link

kiryph commented Mar 28, 2019

MacVim has nothing to do with neovim. It is like gvim for macOS.
MacVim is a graphical frontend for vim.

I think the problem of neovim with :Bclose is not the problem of macvim.

@iberianpig
Copy link
Owner

iberianpig commented Mar 28, 2019

I understand it.
Now, tig-explorer.vim is not using term.
Because this plugin was originally written in a version without term (vim 8.0 and earlier).

To implement for MacVim or Gvim, you should try to use term in if has('gui_macvim') or has('gui_running') statement.

@iberianpig
Copy link
Owner

it works with #15 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants