Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aria-*] attributes do not match their roles when Box is set to Center #177

Open
arnelap opened this issue Mar 30, 2023 · 0 comments
Open

Comments

@arnelap
Copy link

arnelap commented Mar 30, 2023

With a Boxzilla box set to show centered, Google PageSpeed will show an Aria / Accessibility error:

[aria-*] attributes do not match their roles when Box is set to Center
body.home > div#boxzilla-overlay-23
<div aria-modal="true" id="boxzilla-overlay-23" class="boxzilla-overlay boxzilla-23-overlay" style="">

The aria label is applied to the overlay, instead of the box itself and looking at https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-modal I believe it should be applied to the box instead.
However, I tried moving it to the box and I still got the error from Google PageSpeed insights when the box is centered.

Removing the this.overlay.setAttribute('aria-modal', true); when box is centered "solved" the warning...

Now, do you want to be compliant with Aria, or do you want Google to think you are?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant