Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AMP #457

Closed
arnelap opened this issue Jul 24, 2017 · 4 comments · Fixed by #669
Closed

Support AMP #457

arnelap opened this issue Jul 24, 2017 · 4 comments · Fixed by #669
Labels

Comments

@arnelap
Copy link
Contributor

arnelap commented Jul 24, 2017

MC4WP gives errors on AMP compatibility: https://search.google.com/test/amp

Please inform:
https://secure.helpscout.net/conversation/401579136/11203/?folderId=253120
https://wordpress.org/support/topic/amp-error-invalid-value-for-html-attribute-style-in-tag-label/

@arnelap
Copy link
Contributor Author

arnelap commented Feb 18, 2019

@westonruter
Copy link

@arnelap Hi there. I lead development of the official AMP plugin for WordPress. A support topic regarding your plugin was added to the AMP plugin forum which I was helping to troubleshoot: https://wordpress.org/support/topic/form-error-on-2-pages/

I'd be happy to assist you with adding AMP compatibility for your plugin.

@claudiulodro
Copy link
Contributor

@arnelap I have a PR to add AMP-compatibility to MC4WP at Automattic/newspack-plugin#402. We would definitely prefer to have this enhancement upstream so that the wider community benefits from it. Do you want the improvement in this plugin? I can open a PR if so.

@dannyvankooten
Copy link
Member

Hey @claudiulodro,

That'd be very welcome, I'd love to take a look and have this in the plugin. Already went through your code real quick and it looks good to me at first sight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants