Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: use kitten icat for previewing images #1136

Closed
1 task done
yujinyuz opened this issue Apr 15, 2024 · 2 comments
Closed
1 task done

Feature: use kitten icat for previewing images #1136

yujinyuz opened this issue Apr 15, 2024 · 2 comments
Labels
upstream An issue upstream (neovim, fzf, etc) wontfix This will not be worked on

Comments

@yujinyuz
Copy link

Have you RTFM'd?

  • I have done proper research

Feature Request

When you run kitten icat /path/to/img.jpeg it displays the image properly within the terminal.

image

I tried using that command as a previewer but can't seem to get it to work.

image
    previewers = {
      builtin = {
        extensions = {
          ['png'] = { 'kitten', 'icat' },
          ['webp'] = { 'kitten', 'icat' },
          ['jpg'] = { 'kitten', 'icat' },
        },
      },
    },

It also works with the fzf-preview.sh command provided inside fzf's repository

image
@yujinyuz yujinyuz added the feature request New feature label Apr 15, 2024
@ibhagwan
Copy link
Owner

ibhagwan commented Apr 15, 2024

Not sure why you're getting the binary file message (probably misconfiguration).

In any event, this cannot work as kitty icat isn't supported inside a neovim terminal (neovim/neovim#12991), try to display an imagei in a neovim terminal and you'll see this:
image

@ibhagwan ibhagwan added wontfix This will not be worked on upstream An issue upstream (neovim, fzf, etc) and removed feature request New feature labels Apr 15, 2024
@yujinyuz
Copy link
Author

@ibhagwan Shame that it doesn't work on neovim (yet). Anyway thanks for the prompt response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream An issue upstream (neovim, fzf, etc) wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants