Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:FzfLua buffers, git_stash, git_status, tabs doesnt work #735

Closed
I-Own-You opened this issue Apr 22, 2023 · 6 comments
Closed

:FzfLua buffers, git_stash, git_status, tabs doesnt work #735

I-Own-You opened this issue Apr 22, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@I-Own-You
Copy link

Info

  • Operating System: Kubuntu 22.04
  • Shell: zsh
  • Terminal: kitty
  • nvim --version: 0.9.0
  • fzf --version: 0.29(devel)
  • [X ] The issue is reproducible with mini.sh
fzf-lua config is the default one

Description

i noticed you did some commits for past 3 days, after that commits, now, 4 commands are broken for me:

  1. :FzfLua buffers - the window flickers and doesnt show
  2. :FzfLua git_stash - the window flickers and doesnt show
  3. :FzfLua tabs - the window flickers and doesnt show
  4. :FzfLua git_status - the whole neovim just crashes

Here is a video for better understanding

vokoscreenNG-2023-04-23_01-18-35.mp4
@ibhagwan
Copy link
Owner

ibhagwan commented Apr 22, 2023

I suspect this is due to the fact the UI improvements use the fzf’s reload action and you have a fairly old fzf (0.29).

  • Do you have any error in :messages?
  • Can you try :FzfLua git_status reload_actions=false?
  • I would recommend you also upgrade your fzf but this should work regardless as reload was added in 0.19 per the change log so I’m not sure why this fails

@ibhagwan ibhagwan added the bug Something isn't working label Apr 22, 2023
@I-Own-You
Copy link
Author

I suspect this is due to the fact the UI improvements use the fzf’s reload action and you have a fairly old fzf (0.29).

  • Do you have any error in :messages?
  • Can you try :FzfLua git_status reload_actions=false?
  • I would recommend you also upgrade your fzf but this should work regardless as reload was added in 0.19 per the change log so I’m not sure why this fails

:messages - no errors
:FZfLua buffers reload_actions=false - opens normally
:FzfLua git_status reload_actions=false - opens normally
:FzfLua git_stash reload_actions=false - kinda buggy, on one project it opens on another it flickers
:FzfLua tabs reload_actions=false - flickers anyway

I didnt even know my fzf is old, i just installed it as always from apt repo, i swear ill switch to arch regardless of rolling release fear

@ibhagwan
Copy link
Owner

64c980d - this disables the reload actions UX improvements if fzf < 0.36 (just tested from 0.29 - 0.36), update to the latest commit it should solve your issue.

@I-Own-You
Copy link
Author

64c980d - this disables the reload actions UX improvements if fzf < 0.36 (just tested from 0.29 - 0.36), update to the latest commit it should solve your issue.

already updated, thanks

@ibhagwan
Copy link
Owner

64c980d - this disables the reload actions UX improvements if fzf < 0.36 (just tested from 0.29 - 0.36), update to the latest commit it should solve your issue.

already updated, thanks

And everything is in order including tabs?

@I-Own-You
Copy link
Author

64c980d - this disables the reload actions UX improvements if fzf < 0.36 (just tested from 0.29 - 0.36), update to the latest commit it should solve your issue.

already updated, thanks

And everything is in order including tabs?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants