Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace handwritten parser with library #2977

Merged
merged 3 commits into from Sep 15, 2021
Merged

refactor: replace handwritten parser with library #2977

merged 3 commits into from Sep 15, 2021

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Sep 14, 2021 •
edited

This PR replaces our current handwritten parser with a parser combinator
produced by the parsy library.

Closes #2975.

Depends on conda-forge/staged-recipes#16171

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2021 •
edited

Unit Test Results

       19 files         19 suites   1h 29m 32s ⏱️
10 755 tests   8 401 ✔️   2 354 💤 0 ❌
54 459 runs  41 185 ✔️ 13 274 💤 0 ❌

Results for commit f6a345b.

♻️ This comment has been updated with latest results.

@cpcloud cpcloud added the refactor Issues or PRs related to refactoring the codebase label Sep 14, 2021
@jreback
Copy link
Contributor

jreback commented Sep 14, 2021

can you add a release note (indicating now depending on this) & that some parsing error result types might change. Also does this need to be in the official requirements somewhere? (setup.py) / readme

@cpcloud
Copy link
Member Author

cpcloud commented Sep 14, 2021

can you add a release note (indicating now depending on this) & that some parsing error result types might change. Also does this need to be in the official requirements somewhere? (setup.py) / readme

Release note added.

requirements.txt and environment.yml have both been updated, though see the PR description, as I'm waiting on a feedstock to be created conda-forge/staged-recipes#16171.

@jreback jreback added this to the Next release milestone Sep 14, 2021
@cpcloud
Copy link
Member Author

cpcloud commented Sep 14, 2021

@jreback I think this is good to go, the previous build passed. I think we can merge when the current build is green :)

jreback
jreback approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jreback jreback merged commit f6a345b into ibis-project:master Sep 15, 2021
@cpcloud cpcloud deleted the parsy-replace branch October 21, 2021 11:01
@cpcloud cpcloud modified the milestones: Next release, 2.x Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
refactor Issues or PRs related to refactoring the codebase
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

REF: Remove the handwritten type parser
2 participants
@cpcloud @jreback