Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable flake-bugbear and flake8-2020 and fix lints #5102

Merged
merged 1 commit into from Jan 2, 2023

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Dec 30, 2022

This PR enables the flake8-bugbear plugin and fixes associated lints, most of which are assert False usage and calling functions in default arguments. flake8-2020 is also enabled, and there were no existing violations thereof.

@cpcloud cpcloud added this to the 4.0.0 milestone Dec 30, 2022
@cpcloud cpcloud added the developer-tools Tools related to ibis development label Dec 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2022

Test Results

       43 files         43 suites   1h 40m 20s ⏱️
12 943 tests   9 827 ✔️   3 116 💤 0
44 919 runs  33 732 ✔️ 11 187 💤 0

Results for commit 51e045f.

♻️ This comment has been updated with latest results.

@kszucs kszucs merged commit aa3aeca into ibis-project:master Jan 2, 2023
@cpcloud cpcloud deleted the flake8-bugbear-plugin branch January 2, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-tools Tools related to ibis development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants