Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add ibis.join() to docs #7895

Closed
wants to merge 1 commit into from
Closed

docs: add ibis.join() to docs #7895

wants to merge 1 commit into from

Conversation

NickCrews
Copy link
Contributor

@NickCrews NickCrews commented Jan 3, 2024 •
edited

Looks like this:

image

@lostmygithubaccount
Copy link
Member

lostmygithubaccount commented Jan 4, 2024 •
edited

I think we need to update this doc too? https://ibis-project.org/tutorials/ibis-for-sql-users.html#joins

not necessarily in this PR

@cpcloud cpcloud deleted the branch ibis-project:master January 4, 2024 10:43
@cpcloud cpcloud closed this Jan 4, 2024
@cpcloud
Copy link
Member

cpcloud commented Jan 4, 2024

@NickCrews Can you reopen a new PR against main? Sorry about the churn, hopefully it's a one-time thing!

@NickCrews NickCrews mentioned this pull request Jan 5, 2024
Merged
cpcloud pushed a commit that referenced this pull request Jan 5, 2024
@NickCrews
docs: add ibis.join() to docs (#7913)
de2e282 
redo of #7895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostmygithubaccount lostmygithubaccount lostmygithubaccount approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickCrews @lostmygithubaccount @cpcloud