Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add zones geojson example #8040

Merged
merged 4 commits into from Jan 22, 2024

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 19, 2024

Adds a zones geospatial data example

Closes #7958.

@cpcloud cpcloud added this to the 8.0 milestone Jan 19, 2024
@cpcloud cpcloud added feature Features or general enhancements examples Issues/PRs related to `ibis.examples` labels Jan 19, 2024
@ncclementi
Copy link
Contributor

We should add a test that looks something like this:

def test_load_geo_example():
    pytest.importorskip("duckdb")
    
    con = ibis.duckdb.connect()
    
    t = getattr(ibis.examples, "zones").fetch(backend=con)
    assert t.columns == ['zone', 'LocationID', 'borough', 'x_cent', 'y_cent', 'geometry']

@ncclementi
Copy link
Contributor

xref, closes: #7958

Copy link
Contributor

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cpcloud this LGTM!

@cpcloud cpcloud merged commit 2d562b7 into ibis-project:main Jan 22, 2024
79 checks passed
@cpcloud cpcloud deleted the zones-example branch January 22, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issues/PRs related to `ibis.examples` feature Features or general enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add an example geo dataset to ibis.examples
2 participants