feat(api): count nulls with topk #8531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpcloud
added
feature
cpcloud
force-pushed
the
topk-count-nulls
branch
2 times, most recently
from
0de09d6
to
b67bbc2
Compare
|
related, since this is breaking perhaps want to consider these both at the same time: #8540 |
cpcloud
force-pushed
the
topk-count-nulls
branch
2 times, most recently
from
115860a
to
3a889bd
Compare
|
@NickCrews Making column names match should be done in a separate PR |
BREAKING CHANGE: `expr.topk(...)` now includes null counts. The row count of the `topk` call will not differ, but the number of nulls counted will no longer be zero. To drop the `null` row use the `dropna` method.
cpcloud
force-pushed
the
topk-count-nulls
branch
from
3a889bd
to
680d97d
Compare
cpcloud
added
the
ci-run-cloud
ibis-docs-bot
bot
removed
the
ci-run-cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to count star instead of count(expr) in topk API. Closes #8518.
BREAKING CHANGE:
expr.topk(...)now includes null counts. The row count of thetopkcall will not differ, but the number of nulls counted will no longer be zero. To drop thenullrow use thedropnamethod.