Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(pyspark): export functions don't take param or limit #8898

Closed
1 task done
deepyaman opened this issue Apr 5, 2024 · 2 comments · Fixed by #9364
Closed
1 task done

bug(pyspark): export functions don't take param or limit #8898

deepyaman opened this issue Apr 5, 2024 · 2 comments · Fixed by #9364
Labels
bug Incorrect behavior inside of ibis onboarding Issues that can be addressed by someone less familiar with ibis

Comments

@deepyaman
Copy link
Contributor

What happened?

Expect to be able to pass param or limit, as with other backends.

What version of ibis are you using?

8

What backend(s) are you using, if any?

PySpark

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@deepyaman deepyaman added bug Incorrect behavior inside of ibis onboarding Issues that can be addressed by someone less familiar with ibis labels Apr 5, 2024
@alperentahta
Copy link

Could you please give more information, I can take this task

@deepyaman
Copy link
Contributor Author

deepyaman commented Jun 5, 2024

Could you please give more information, I can take this task

If you look at the to_delta() implementation, you'll notice that the signature doesn't take params, but the base implementation does. params could be passed to the compile() call in to_delta().

This issue occurred in more places when I originally filed it; may just be a very minimal fix now, if anything? It seems like a number of the special export functions are removed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect behavior inside of ibis onboarding Issues that can be addressed by someone less familiar with ibis
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants